Fix proxy script use #552
Merged
Fix proxy script use #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a proxy configuration script (aka wpad pac script), the actual proxy settings you get depend on the url you target. It's used for load balancing / web proxy routing in enterprises. If you were unlikely enough (like me) to have a split between google urls and the rest of the www, the current code would use the google proxy to target github urls, which was failing (405 in my case but I guess that could depend on the actual setup).
|
/cc @vasily-kirichenko would this work for you? |
|
It should work. "google.com" was chosen in a random basis. Please merge it and release so I can test it. |
forki
added a commit
that referenced
this pull request
Jan 15, 2015
|
Works OK for me. |
|
Today won't be the day where I make my first F# contribution 😭 |
|
Sorry about that.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a proxy configuration script (aka wpad pac script), the actual
proxy settings you get depend on the url you target.
It's used for load balancing / web proxy routing in enterprises.
If you were unlikely enough (like me) to have a split between google urls
and the rest of the www, the current code would use the google proxy
to target github urls, which was failing (405 in my case but I guess
that could depend on the actual setup).
(this code is part 1/2 to fix the bootstrapper, paket code needs a similar fix as well)