Don't add Nuget package twice to ReferencesFile - fixes #454 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
added a commit
that referenced
this pull request
Dec 20, 2014
Don't add Nuget package twice to ReferencesFile - fixes #454
| @@ -20,21 20,12 @@ let Add(dependenciesFileName, package, version, force, hard, interactive, instal | |||
| LockFile.LoadFrom(lockFileName.FullName) | |||
|
|
|||
| if interactive then | |||
| let (PackageName package) = package | |||
| let (PackageName packageName) = package | |||
There was a problem hiding this comment.
packageName is not used in any way, it can be removed.
There was a problem hiding this comment.
Yep I noticed that too.
On Dec 21, 2014 1:26 AM, "Max Malook" [email protected] wrote:
In src/Paket.Core/AddProcess.fs
#460 (diff):@@ -20,21 20,12 @@ let Add(dependenciesFileName, package, version, force, hard, interactive, instal
LockFile.LoadFrom(lockFileName.FullName)if interactive then
let (PackageName package) = packagelet (PackageName packageName) = packagepackageName is not used in any way, it can be removed.
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/460/files#r22144892.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.