Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reference satellite assemblies - fixes #439 #444

Merged
merged 2 commits into from
Dec 9, 2014
Merged

Conversation

forki
Copy link
Member

@forki forki commented Dec 9, 2014

No description provided.

@isaacabraham
Copy link
Contributor

Cool, looks good. Might have to read up on satellites to see how they actually get deployed by NuGet but for now this is fine

forki added a commit that referenced this pull request Dec 9, 2014
Don't reference satellite assemblies - fixes #439
@forki forki merged commit 4194214 into master Dec 9, 2014
@forki forki deleted the satellite branch December 9, 2014 10:10
| _ -> false

let excludeSatelliteAssemblies = function
| Reference.Library lib -> lib.EndsWith "resources.dll"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be extended to check for ".resources.dll", otherwise dlls like SomeResources.dll would also be filtered out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants