Fix exception when searching for config file #4138
Conversation
|
|
||
| /// Finds all project files | ||
| static member FindAllProjectFiles folder : FileInfo [] = | ||
| ProjectFile.SearchAllProjectRelatedFiles "*proj*" folder |
There was a problem hiding this comment.
that's not the same pattern as we did above, right? This would include "MyprojectFile.fs" or stuff like that
There was a problem hiding this comment.
This is the same as what it was originally (see L1902). Yes it would, but it gets filtered out anyway in the next line.
Do you think I should change it to "*.*proj"?
| @@ -83,17 83,6 @@ let internal indentAssemblyBindings config = | |||
| if not parent.HasElements then | |||
| parent.Remove() | |||
|
|
|||
| let private configFiles = [ "app"; "web" ] |> Set.ofList | |||
| let private projectFiles = [ ".csproj"; ".vbproj"; ".fsproj"; ".wixproj"; ".nproj"; ".vcxproj"; ".pyproj"; ".sfproj"; ".sqlproj" ] |> Set.ofList | |||
There was a problem hiding this comment.
I think we need to keep this ugly explicit list
There was a problem hiding this comment.
What for? It's private, not used anywhere, and is just a duplicating the list in ProjectFile.fs
There was a problem hiding this comment.
wasn't this was filtered things to "*.*proj"?
There was a problem hiding this comment.
No, not since aac9770
|
Thanks for the quick merge and release! |
Fixes #4137