NuGet Cache: avoid duplicate nupkg file #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the super fast release! 🚀 |
This was referenced Mar 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Paket ends up putting each nupkg file twice into the NuGet cache: once in the folder of the package, and once in the subfolder for the specific version. NuGet itself puts it only into the version subfolder - as did Paket before v6.
The reason for this seems to be that we first download the nupkg to the expected folder. However, because NuGet's PackageExtractor.InstallFromSourceAsync doesn't support inplace extraction where the nupkg is already there in the correct place, we first move it to the parent folder and then extract from there.
The proposed change would delete that file in the parent folder after the extraction.
Advantage of deleting: