Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollForward strategy for CLI tool #4089

Merged
merged 1 commit into from
Oct 13, 2021
Merged

RollForward strategy for CLI tool #4089

merged 1 commit into from
Oct 13, 2021

Conversation

sergey-tihon
Copy link
Member

attempt to fix #4088

@Dolfik1
Copy link
Contributor

Dolfik1 commented Oct 13, 2021

It looks like there is problem on CI. @forki could you check it?

@forki forki merged commit b5cecd5 into master Oct 13, 2021
@forki forki deleted the sergey-tihon-patch-1 branch October 13, 2021 08:52
@Dolfik1
Copy link
Contributor

Dolfik1 commented Oct 13, 2021

@forki Paket 6.2.0

dotnet paket restore
It's invalid to use both `rollForward` and one of `rollForwardOnNoCandidateFx` or `applyPatches` in the same runtime config.
Invalid runtimeconfig.json [/Users/nikolay/.nuget/packages/paket/6.2.0/tools/netcoreapp2.1/any/paket.runtimeconfig.json] [/Users/nikolay/.nuget/packages/paket/6.2.0/tools/netcoreapp2.1/any/paket.runtimeconfig.dev.json]

@forki
Copy link
Member

forki commented Oct 13, 2021

I tried this in Paket 6.2.0. But then we get

It's invalid to use both rollForward and one of rollForwardOnNoCandidateFx or applyPatches in the same runtime config.

Any ideas?

@vshapenko
Copy link

@vshapenko
Copy link

@forki , looks similar to following:
To reconcile the various scopes the host will apply the following precedence:

environment variable DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX
.runtimeconfig.json global setting - rollForward and rollForwardOnNoCandidateFx (it's invalid to specify both)
.runtimeconfig.json per-framework setting - rollForward and rollForwardOnNoCandidateFx (it's invalid to specify both)
environment variable DOTNET_ROLL_FORWARD
command line arguments - rollForward and rollForwardOnNoCandidateFx (it's invalid to specify both)

@sergey-tihon
Copy link
Member Author

Looks like <RollForward> conflicts with

"rollForwardOnNoCandidateFx": 2

@forki
Copy link
Member

forki commented Oct 30, 2021

can someone please send another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET 6 Release Candidate 1
4 participants