unify the setting of version package metadata in the 461 and .net core builds of Paket #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore builds of Paket
|
this is what I get locally |
|
There's a hard coded test that I'm not sure has value anymore now that we're leaning on standard .net versioning metadata. I can look into it and see if there's a way to keep it to verify end to end, while not remaining hard coded. |
This was referenced Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4082
The merged .Net Framework 4.6.1 build of paket.exe used the 'raw' published binaries build from the
publishstep of the build script, which themselves used the raw outputs of thebuildstep of the build script. Thisbuildstep didn't assign version numbers to the version msbuild properties, and so that now-required metadata was no longer present.This MR therefore
Verification of this can be seen by using ilspy or another decompiler to look at the AssemblyInformationalVersion attributes of the
tools/paket.exeandtools/netcoreapp2.1/paket.dllfiles, which both should be 6.1.0 a build hash after this change.