Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify packaging strategy for Paket.Core #4080

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented Aug 31, 2021

This MR

  • packs Paket.Core using the .net SDK integration instead of paket.template files
  • removes custom assemblyinfo generation in favor of the automatic msbuild generation
  • uses embedded Icons in the packages (as is the new hotness)
  • enables sourcelink on every published artifact from this repo in the new way

I'll drop a before/after comparison of the current published nuget packages in a bit, but initial explorations via the online nuget browser have been very heartening!

@forki
Copy link
Member

forki commented Sep 1, 2021

any ideas why build is red?

@baronfel
Copy link
Contributor Author

baronfel commented Sep 3, 2021

@forki no idea really, it just seems to be the paket FSI integration. Will take a look.

@baronfel
Copy link
Contributor Author

baronfel commented Sep 3, 2021

Paket.Core (before)

metadata and file layout

dependencies

note that Nuget.Packaging is off in this release?

assembly attributes

Paket.Core (after)

metadata and file layout

note the addition of the logo to the package, and the embedded PDBs now

dependencies

assembly attributes

I've included the built packages at this commit if you want to check them out:
packages-for-this-commit.zip

@forki
Copy link
Member

forki commented Sep 13, 2021

what's the status here?

@baronfel
Copy link
Contributor Author

Closing the loop on that filling test and presenting detailed diffs of the two versions for all packed Nugets after this change. Hard finding time ATM, sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants