Added NoDefaultExcludes #4038
Merged
Added NoDefaultExcludes #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
This was referenced Oct 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my very first PR, and I am scared and excited at the same time, 🙀
When I was making templates for use with dotnet core, and these templates contained .files i.e.
.editorconfig, etc, then these files would not be added to the package on executing dotnet pack.I would receive a warning stating that it was not going to add the .files to the package and to specify
-NoDefaultExcludesto the command line. So I would add it to the csproj instead and then noticed that this Paket.Restore.targets did not contain the option to pass on.I am a little fresh to this project, so I haven't looked around in here much.
I have assumed that this is the correct place, to update this file as I believe this is where it comes from when a
paket restoreis executed.I may also need a little help to work out what/where would be a good place to add a test for this? If there are tests around this already?
Also I started to try to make this change on a branch from
bugfixbut it seems there is something broken about that branch, I can't seem to run the ./build.sh as I receive TlsException: CertificateUnknown and when I go to the feed, it seems something is wrong.I think I would like to be able to add this to bugfix and have a new 5.258.0 release maybe, (but again I am not sure on this process either)