Fix how msbuild condition is created based on target frameworks #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2020 10:32
…TargetFramework based condition
|
the travis is red. unfortunately |
|
@forki I checked it and it seems like some infrastructure problem: |
|
ok let's rerun this |
This was referenced Oct 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is fix of #3939
The problem was that when you used in proj file e.g. target framework net5.0-windows it was not matching msbuild condition '$(TargetFramework)' == 'net5.0-windows7.0' which was created for the net5.0-windows target framework.
Generally, there are many ways how to write the same TargetFramework. Hence, I switched to the form like "($(TargetFrameworkIdentifier) == '.NETCoreApp' And ($(TargetFrameworkVersion) == 'v5.0' And '$(TargetPlatformIdentifier)' == 'Windows'))" like it was done on other place in Paket