Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AES encryption when not on windows #3884

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Use AES encryption when not on windows #3884

merged 2 commits into from
Jul 23, 2020

Conversation

bengobeil
Copy link
Contributor

(cherry picked from commit b22361c)

@bengobeil
Copy link
Contributor Author

If we can release this today, it will be very helpful for us. Thanks!

@forki
Copy link
Member

forki commented Jul 23, 2020

image

@bengobeil
Copy link
Contributor Author

What are the repro steps?

@bengobeil
Copy link
Contributor Author

Oh its just doesn't build... one sec

@bengobeil
Copy link
Contributor Author

Oh, probably a different lang version on 5.XXX ?

@forki
Copy link
Member

forki commented Jul 23, 2020

yes it's old school ;-)

@bengobeil
Copy link
Contributor Author

OK, it was a case of implicit yields

@forki
Copy link
Member

forki commented Jul 23, 2020

Cool. Will release as soon as I'm back home

@bengobeil
Copy link
Contributor Author

Great thanks!

@forki forki merged commit cbd659d into fsprojects:bugfix Jul 23, 2020
This was referenced Oct 11, 2021
Closed
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bengobeil @forki