Do not add development dependencies to the nuspec of a target nupkg while paket packing #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache, then we return a Nuspec.All which even causes development dependencies to be added to the resultant nuspec and is not correct behavior. This can be remedied by searching for the dependency in the DefaultPackagesFolder before giving up and using Nuspec.All. This change intoduces this methodology.
ruhullahshah
changed the title
|
thanks a lot for taking care of this |
|
You are welcome |
This was referenced Oct 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It was observed on some systems that
paket packadds development dependencies to the nuspec of a target nuget package.The root cause for this has been documented here. This PR aims to fix issue #3723
Description of fix:
If a nupkg does not exist in the local nuget cache, try to load the nuspec from the
DefaultPackagesFolderbefore returning aNuspec.All