Update matching platform check 🚀 #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os:mono` and `os:windows` are behaving wrongly for .Net Core version of the Paket. This is caused by the fact the check depends on `isMonoRuntime` function which on .Net Core always return `false` which caused `os:mono` to never be matched, and `os:windows` be matched on all platforms. The workaround for the problem is to use `os:win`, `os:linux` and `os:osx` - but it's breaking change for anyone already using those checks who just wanted to modernize build infrastructure (👋). Fix makes old syntax works correctly also on .Net Core by using the same checks as for `os:win`, `os:osx` and `os:linux`. `os:windows` will behave just like `os:win` and `os:mono` will be `os:osx || os:linux`
This was referenced Oct 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os:monoandos:windowsare behaving wrongly for .Net Core version of the Paket. This is caused by the fact the check depends onisMonoRuntimefunction which on .Net Core always returnfalsewhich causedos:monoto never be matched, andos:windowsbe matched on all platforms.The workaround for the problem is to use
os:win,os:linuxandos:osx- but it's breaking change for anyone already using those checks who just wanted to modernize build infrastructure (👋).Fix makes old syntax works correctly also on .Net Core by using the same checks as for
os:win,os:osxandos:linux.os:windowswill behave just likeos:winandos:monowill beos:osx || os:linux