Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/issue #3763 partially extracted nugets #3764

Merged
merged 2 commits into from
Dec 22, 2019

Conversation

viktor-svub
Copy link
Contributor

fixing partial nuget extraction #3763 by extending fixes for borked and leaky zips to catch more cases

@forki forki requested a review from matthid December 22, 2019 07:07
@forki forki merged commit 7e6289e into fsprojects:master Dec 22, 2019
@forki
Copy link
Member

forki commented Dec 22, 2019

This is released in v6 alpha channel. Can you please test it out and then I'll push it to v5 as well. Thanks for your help!

@viktor-svub
Copy link
Contributor Author

Verified 6.0.0-alpha009 with previously failing dependencies -- the expected yellow warning "Trying to extract files individually" shows up, and the packages are fully extracted and work correctly in dotnet restore/build/run. Thank you!

@viktor-svub
Copy link
Contributor Author

It seems version 5.241.3 has some new merge/build issue -- paket install ends with:

Paket failed with
-> Resource stream 'Paket.Restore.targets' could not be found in the Paket.Core assembly

It happens on all install attempts, regardless of .paket\Paket.Restore.targets presence, and the file indeed does not re/appear with this version when not present.

It does not happen when 6.0.0-alpha009 is used for install, regardless if fresh or using 5.241.3 bootstrapper with version in paket.dependencies to use the alpha.

@forki
Copy link
Member

forki commented Dec 22, 2019 via email

@forki
Copy link
Member

forki commented Dec 22, 2019

Ok never mind. It's still broken. Seems I need to dig deeper tomorrow.

@forki
Copy link
Member

forki commented Dec 22, 2019

ok released 5.241.5 and that one seems to work. I had to install VS 2019 because it used a wrong compiler version. ffs

@viktor-svub
Copy link
Contributor Author

thank you! 5.241.5 works perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants