Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do only disable automagic when FSharp.Core is actually used #3725

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Do only disable automagic when FSharp.Core is actually used #3725

merged 2 commits into from
Nov 15, 2019

Conversation

forki
Copy link
Member

@forki forki commented Nov 15, 2019

fixes #3721

@forki forki requested a review from matthid November 15, 2019 14:05
@forki forki mentioned this pull request Nov 15, 2019
Closed
matthid
matthid approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like all the mutables we introduce in these fixes but the behavior change sounds reasonable

@forki
Copy link
Member Author

forki commented Nov 15, 2019

@matthid then how about b8507bb?

@matthid
Copy link
Member

matthid commented Nov 15, 2019

I'm not a functional purist :) As long as it works. But yes thanks for taking care of this nit!

@forki forki merged commit b8507bb into master Nov 15, 2019
@forki forki deleted the i3721 branch November 15, 2019 15:27
@forki forki mentioned this pull request Jan 4, 2020
Open
forki added a commit that referenced this pull request Jan 4, 2020
@forki
Revert #3725
afa06b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlemann atlemann atlemann left review comments

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A new project fails to run
3 participants
@forki @matthid @atlemann