Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try hardcoded path for NuGetFallbackFolder #3663

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

rfrerebe
Copy link

in addition to BinFolder (working only on windows)

#3662

in addition to BinFolder (working only on windows)
| true ->
[|"/usr/share/dotnet/sdk/NuGetFallbackFolder" |]
| false ->
[| @"C:\Program Files\dotnet\sdk\NuGetFallbackFolder";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should read the beginning of the path from env settings

@forki forki merged commit 4a3357b into fsprojects:master Sep 24, 2019
@forki
Copy link
Member

forki commented Sep 24, 2019

thanks. Can you please try 5.219.4 - I tried to make it slightly more correct with using env variables

@rfrerebe
Copy link
Author

Hello,
I can confirm that issue is fixed using 5.219.4
Thanks for the merge 🚀

About env variables, I can submit a new PR.
I tried to use NuGetCachePath following https://fsprojects.github.io/Paket/caches.html#NuGet-machine-cache
but it did not work.
Is it what your are talking about ?

@rfrerebe
Copy link
Author

Thanks I have seen your commit.
I learned somethign with the use of lazy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants