Fix fast restore #3608
Fix fast restore #3608
Conversation
|
/cc @TheAngryByrd Please check if this regresses on #2796 |
|
Seems to be working for me! Only issue I seemed to have is having an older FAKE version causes |
|
I think we should fix that, if we cannot read the cache file we should probably call restore and consider it outdated |
|
Seems the testsuite agrees ;) |
|
is this ready? |
|
Should be ready if it turns green. I addressed the failing tests and the issue @TheAngryByrd pointed out (including a test for this scenario as none existed) Notice that this also fixes fsprojects/FAKE#2348 which apparently is a feature now in the SAFE-Stack. Instead of adding an integration test into FAKE, I think it should be enough that we now have one here, time will tell. |
|
I accidentally pushed into |
|
@matthid you always find novel ways to confuse me ;-) |
|
That's why I added a comment ;). |
|
You could point origin to your fork and name the common fork upstream
Matthias Dittrich <[email protected]> schrieb am Di., 2. Juli 2019,
19:47:
… That's why I added a comment ;).
push origin is just to much muscle memory ;)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3608?email_source=notifications&email_token=AAAOANBLLF5ZD6S5OU5UVRDP5OIBZA5CNFSM4H4WQFWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCBRCQ#issuecomment-507779210>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANEASK632R7RJFAVCZLP5OIBZANCNFSM4H4WQFWA>
.
|
|
That's what I do, too terrified I'll flub things up by happenstance |
|
Had to fix another test anyway, so back to normal ;) |
This has regressed countless times:
The last regression was due to the change of the caching file to only contain hashes. This is tricky to fix in msbuild, but there is https://docs.microsoft.com/en-us/visualstudio/msbuild/getfilehash-task?view=vs-2019 which seems to produce the exact same hash we already generate in C# (when using SHA256 in hex format).
I guess this also replaces #2870, lets see if this actually works for everyone, if not we are doomed ;)
Therefore we: