Fix native library detection - enables FAKE native library support #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2019
matthid
commented
Jun 9, 2019
| @@ -533,7 539,7 @@ module InstallModel = | |||
|
|
|||
| let removeIfCompletelyEmpty (this:InstallModel) = | |||
| let foldersEmpty = | |||
| isEmpty this.CompileRefFolders && isEmpty this.TargetsFileFolders && isEmpty this.RuntimeAssemblyFolders && | |||
| isEmpty this.CompileRefFolders && isEmpty this.TargetsFileFolders && isEmpty this.RuntimeAssemblyFolders && isEmpty this.RuntimeLibFolders && | |||
There was a problem hiding this comment.
It seems like this change (or the added trySscanf) or the added tests made it go over the 60minute appveyor limit. However, we need those bugfixes so I disabled some long running tests instead.
@forki can we merge this as is?
matthid
changed the title
|
@forki Somehow Build-Times went down again, not sure what happened. This is ready. |
|
The CI failure is API rate limit. I guess I started too many builds :) |
This was referenced Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues to enable fsprojects/FAKE#2007:
system.data.sqlite.core-> We will emit a warning when we detect this.
#3166 pack multitarget with p2p by tfmto#3558 pack multitarget with p2p by tfm#3165 pack multitarget with p2pto#3317 pack multitarget with p2p