fix multiple dotnet pack invocations with different Version property #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricosada
force-pushed
the
issue3584_pack_version
branch
from
4c58780
to
2472b59
Compare
teo-tsirpanis
approved these changes
May 24, 2019
|
|
||
| let rootPath = scenarioTempPath scenario | ||
|
|
||
| directPaket ("restore") scenario |
There was a problem hiding this comment.
You can remove the parentheses.
| |> ignore | ||
|
|
||
| let nupkgPath = Path.Combine(outPath, sprintf "%s.%s.nupkg" project expectedVersion) | ||
| if File.Exists nupkgPath |> not then Assert.Fail(sprintf "Expected '%s' to exist" nupkgPath) |
There was a problem hiding this comment.
You could have used Assert.True here.
| pack "out1" "/p:Version=1.2.3" "1.2.3" | ||
| pack "out2" "/p:Version=2.3.4" "2.3.4" | ||
|
|
||
|
|
There was a problem hiding this comment.
These lines seem a bit off.
|
@teo-tsirpanis thx for review, good feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3584