Prevent Simplifier removing item if it has settings or version requirements #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With version numbers these tests fail as nothing gets removed.
|
@forki are these build failures mine, or pre-existing. It is quite confusing 😕 |
|
This one is ready |
…removed on simplify
Removal of the warning as this is no longer an issue :)
|
can you please merge with master? |
|
@forki done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when i had any settings or version requirements in references/dependencies files and run a simplify it would remove these items and therefore remove the settings.
Now, as well as the item being implied as a transitive dependency, it also needs to have no settings or version requirements in order to be removed.