Fixes for --no-restore still doing a restore #3486
Conversation
|
Is there a way to template this value so that it could be populated on release builds? I'm just worried about reintroducing this failure transparently down the line. Either that or a more low tech fix: a test that checks if the version in the embedded targets matches the current assembly version? |
BlythMeister
changed the title
|
@baronfel have added comments above the 2 values which need to be in sync. These appear to be values for the format of the data since the value in the props does not match that of paket itself. Have also made an additional change to the |
|
Scrap that before target stuff...that's just plain wrong...will rebase and fix up this PR :D |
Also add a comment to hint that these should be kept in sync
BlythMeister
force-pushed
the
norestore
branch
from
280cffc
to
0dd27ac
Compare
|
also looking at the changes which changed one of these files, i think it was known that they need to be kept in sync...but the wrong targets was changed :) The one that this repo actually uses to build was changed, not the one that paket puts into repos :D |
|
Ouch. Good catch
Am Fr., 18. Jan. 2019, 10:16 hat Chris Blyth <[email protected]>
geschrieben:
… ***@***.**** commented on this pull request.
------------------------------
In src/Paket.Core/embedded/Paket.Restore.targets
<#3486 (comment)>:
> @@ -102,7 102,11 @@
<PaketRestoreRequired Condition=" '$(PaketRestoreLockFileHash)' == '' ">true</PaketRestoreRequired>
</PropertyGroup>
- <PropertyGroup Condition="'$(PaketPropsVersion)' != '5.174.2' ">
<!--
This value should match the version in the props generated by paket
If they differ, this means we need to do a restore in order to ensure correct dependencies
-->
<PropertyGroup Condition="'$(PaketPropsVersion)' != '5.185.3' ">
this commit is when the props version was changed. 828f9e4
<828f9e4>
This file was not updated at that time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3486 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADgNPADXzgC5wN3iRFjuOPqbjtprgqpks5vEZDvgaJpZM4aFgy9>
.
|
|
i'm an experienced archaeology driven developer ;) |
Fixes #3485 and #3449
The version number used in the PaketPropsVersion in https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/Installation/RestoreProcess.fs#L328 is
5.185.3which does not match the targets.This means that
PaketRestoreRequiredis always true, even if you have literally just built.