Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new option to control interproject references version constraint #3473

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

lexarchik
Copy link
Contributor

#2520
New cli parameter and templatefile option interproject-references.
Possible values are min, fix, keep-major, keep-minor, keep-patch.

This makes --pin-project-references obsolete.

@lexarchik lexarchik changed the title I2520 new option to control inverproject references version constraint Jan 8, 2019
@lexarchik lexarchik changed the title new option to control inverproject references version constraint new option to control interproject references version constraint Jan 8, 2019
@forki forki requested a review from agross January 13, 2019 19:46
Copy link
Contributor

@agross agross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I commented on some spelling mistakes. Please correct them.

docs/content/commands/pack.md Outdated Show resolved Hide resolved
docs/content/commands/pack.md Outdated Show resolved Hide resolved
docs/content/commands/pack.md Outdated Show resolved Hide resolved
docs/content/template-files.md Outdated Show resolved Hide resolved
docs/content/template-files.md Outdated Show resolved Hide resolved
docs/content/template-files.md Outdated Show resolved Hide resolved
docs/content/template-files.md Outdated Show resolved Hide resolved
docs/content/template-files.md Outdated Show resolved Hide resolved
docs/content/template-files.md Outdated Show resolved Hide resolved
src/Paket/Commands.fs Outdated Show resolved Hide resolved
@lexarchik
Copy link
Contributor Author

Thank you for review :)
Just made fixes.

src/Paket/Commands.fs Outdated Show resolved Hide resolved
@agross
Copy link
Contributor

agross commented Jan 14, 2019

@lexarchik Thank you. I read a second pass and have made some more comments. The new docs will shine ;-)

@lexarchik
Copy link
Contributor Author

@agross thanks)

@forki
Copy link
Member

forki commented Jan 18, 2019

it doesn't build locally for me.

@lexarchik
Copy link
Contributor Author

@forki fixed.
I forgot about Paket.preview3.sln

@lexarchik
Copy link
Contributor Author

@forki Have you reviewed this PR? Are there any problems with it?

@forki forki merged commit 6bad304 into fsprojects:master Feb 3, 2019
@forki
Copy link
Member

forki commented Feb 4, 2019

thanks for this!

@BlythMeister
Copy link
Contributor

@lexarchik @forki this is a breaking change. If you were using interproject-references you are now forced to include the new option.
Was this intentional? - is there no sensible default?

@lexarchik
Copy link
Contributor Author

why is it breaking change?
how including new option is forced?

default value for this option is "min"

@BlythMeister
Copy link
Contributor

I had the option, without anything after (which was ok for a version or 2)
Now it says you have to pass the type e.g. min

@lexarchik
Copy link
Contributor Author

its strange. interproject-references is completly new option. it was added in this pr.
you got error about cli parameter or about option in templatefile?

@BlythMeister
Copy link
Contributor

I got an error saying it expected a parameter after interproject-references

@BlythMeister
Copy link
Contributor

Whereas, I have another option after it...maybe it's just the way the options are parsed...

@lexarchik
Copy link
Contributor Author

can you make a little repro solution that work with older paket version and fail with newer?

@BlythMeister
Copy link
Contributor

Sure, here is the args I pass, copied from my Fake script.
‘‘‘
  let args = sprintf "pack --minimum-from-lock-file --interproject-references --pin-project-references %s" outputDir
‘‘‘
By adding 'min' after the interproject-references paket works.
This was working, and then a recent update caused this to break.

I updated the command to add 'min' and remove the pin-project-references and it started working again.

@lexarchik
Copy link
Contributor Author

and with what version of paket did this work without "min"?

@BlythMeister
Copy link
Contributor

Hmmm...maybe it didn't...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants