Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct request header #3466

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Use the correct request header #3466

merged 2 commits into from
Jan 2, 2019

Conversation

inosik
Copy link
Contributor

@inosik inosik commented Jan 2, 2019

Fixes #3458.

@inosik
Copy link
Contributor Author

inosik commented Jan 2, 2019

Hm, crashes at runtime. I'm looking into that.

@inosik
Copy link
Contributor Author

inosik commented Jan 2, 2019

This is ready now. I followed an answer on SO to fix the runtime error. I also tried to use the Headers.ContentType property to be safe, but the constructor of System.Net.Http.Headers.MediaTypeHeaderValue doesn't accept the value we pass in.

@forki forki merged commit 368d536 into fsprojects:master Jan 2, 2019
@inosik inosik deleted the bugfix/#3458-netcore-push branch January 2, 2019 13:14
@inosik inosik mentioned this pull request Jan 2, 2019
Closed
@haf
Copy link
Member

haf commented Jan 3, 2019

This would not have been an issue had you been using HTTP.fs BTW.

@haf
Copy link
Member

haf commented Jan 3, 2019

Thank you @inosik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inosik @haf @forki