Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add compat fallback in case of older cache files. #3417

Merged
merged 1 commit into from
Nov 13, 2018
Merged

add compat fallback in case of older cache files. #3417

merged 1 commit into from
Nov 13, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Nov 11, 2018

@matthid
Copy link
Member Author

matthid commented Nov 11, 2018

Instead of fixing it like suggested in this PR (this will be a huge compat frustration very soon) we could try the following:

  • Paket writes its version into paket.restore.targets
  • Paket writes its version into the cache
  • The paket.restore.targets logic checks if the cache version matches its own version, if not then
    • run paket --version if the version doesn't match with the restore.targets then fail the build with a message to run paket install or paket restore manually
    • delete paket.restore.cached and run paket restore again (which should replace the cache)

Maybe this is a bit too strict?

@forki forki merged commit 88620a9 into master Nov 13, 2018
@matthid matthid deleted the compat-targets branch July 2, 2019 17:15
@yaakov-h yaakov-h mentioned this pull request Sep 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthid @forki