Adjustable timeouts for NuGet #3383
Conversation
Timeout adjustable for sending request and stream processing.
src/Paket.Core/Dependencies/NuGet.fs
Outdated
| @@ -880,19 881,34 @@ let private downloadAndExtractPackage(alternativeProjectRoot, root, isLocalOverr | |||
| ensureDir targetFileName | |||
|
|
|||
| use _trackDownload = Profile.startCategory Profile.Category.NuGetDownload | |||
| let! tok = Async.CancellationToken | |||
| let taskTimeout = | |||
| match Environment.GetEnvironmentVariable("PAKET_RESOLVER_TASK_TIMEOUT") with | |||
There was a problem hiding this comment.
can we please get some docs for that?
…esponse of the stream for the package to be downloaded and for the read and write stream operations on the package to be downloaded. Add comments to the functionality.
|
We have updated the functionality in the NuGet.fs and added comments to the timeouts. Please let us know if something is missing or if something is unclear. |
|
can you please document it in the docs? Not sure where it would belong, but if you don't find a better place you may formulate it as a FAQ and put it in |
|
We made a short entry in the FAQ and we hope that's enough. |
|
I'm not sure, but shouldn't there be a way to make it work by default without the need to force our users to setup every timeout by hand? |
|
@forki thanks for merging and deploying. Just tested, and after a painstaking 4 minute DL time, restore succeeded. |
|
Could you close the accompanying issue please? @matthid Reworking this now is not a big issue i guess, at least now we can work with paket again. Other fixes would have to be made in Nexus i guess, the Nuget package feed implementation |
|
This created a new issue #3407. Can you please help? |
|
there are multiple people having issues. I'm reverting for now. Let's try to find a solution |
Timeout adjustable for sending request and stream processing.