use WinHttpHandler for downloading as well (Fixup of 3307) #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ET_HTTP_USESOCKETSHTTPHANDLER (mostly for testing)
|
@forki I tried to release this but failed because my nugetkey is no longer valid. Can you update my nuget account to the packages or maybe we could create an organization like we did for fake? Feel free to straight up release from master (already updated the release notes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3307
fsprojects/FAKE#2029
It took me a while to find why it still wasn't working until I realized that only "downloads" were not working, everything else did work fine. Reason is that we used a different API for downloading then for all other calls. This PR just falls back to the already existing logic instead of duplicating everything.