Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert impact of https://github.com/dotnet/corefx/issues/31098 by using WinHttpHandler #3307

Merged
merged 8 commits into from
Jul 30, 2018
Merged

Revert impact of https://github.com/dotnet/corefx/issues/31098 by using WinHttpHandler #3307

merged 8 commits into from
Jul 30, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Jul 22, 2018

In essence the netcore2.1 release broke some use-cases for fake 5 and paket (well the netcore version if it ever exists and Paket.Core) - this tries to restore the old behavior.

See https://github.com/dotnet/corefx/issues/31098

I noticed the following warnings after paket install (but they might have been there before that as I don't see any of those versions changed in this PR):

  Consider app.config remapping of assembly "System.ComponentModel.TypeConverter, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.1.1.0" [] to Version "4.1.2.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.ComponentModel.TypeConverter.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Runtime.Serialization.Primitives, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.1.2.0" [] to Version "4.1.3.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.Runtime.Serialization.Primitives.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Collections.NonGeneric, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.0.2.0" [] to Version "4.0.3.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.Collections.NonGeneric.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Xml.XmlDocument, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "4.0.2.0" [] to Version "4.0.3.0" [C:\Users\matth\.nuget\packages\netstandard.library\2.0.1\build\netstandard2.0\ref\System.Xml.XmlDocument.dll] to solve conflict and get rid of warning.

This was referenced Jul 22, 2018
Closed
Merged
@matthid
Copy link
Member Author

matthid commented Jul 22, 2018

The type 'WinHttpHandler' is not defined oO. I thought I added the nuget package...

@matthid
Copy link
Member Author

matthid commented Jul 22, 2018

The API seems to be compatible for >=net46 only and we still have net45 :(

@matthid
Copy link
Member Author

matthid commented Jul 23, 2018 •
edited
Loading

I'm not sure if the build errors are related to this pr or if I was just unlucky. Some builds in the matrix are definitely green...

@forki forki closed this Jul 24, 2018
@forki forki reopened this Jul 24, 2018
matthid referenced this pull request Jul 28, 2018
@forki
Paket convert-from-nuget doesn't crash on NuGet v2 syntax - fixes #3151
833b36c
@matthid
Copy link
Member Author

matthid commented Jul 28, 2018 •
edited
Loading

It makes no sense that travis started to fail with this PR:

  • All changes are in #if blocks and the full-framework build is exactly the same as before this PR
  • Even if the new code is somehow executed it is in a if isWindows then block in addition to the #if

what the hell?

@matthid
Copy link
Member Author

matthid commented Jul 28, 2018

Maybe because of the paket update or something like that. I'm pretty positive that it is not related to the code change at all.

matthid
matthid commented Jul 28, 2018
View reviewed changes
src/Paket.Core.preview3/Paket.Core.fsproj Outdated
@@ -4,6 4,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<PaketCoreSourcesDir>..\Paket.Core</PaketCoreSourcesDir>
<DefineConstants>NO_BOOTSTRAPPER;NO_CONFIGURATIONMANAGER;CUSTOM_WEBPROXY;$(DefineConstants)</DefineConstants>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paket added this, maybe mono doesn't like that

@matthid
Copy link
Member Author

matthid commented Jul 28, 2018

Intesting. master seems to have the same problem now. So I guess I was unlucky again and something changed outside of this PR

@matthid
Copy link
Member Author

matthid commented Jul 28, 2018

travis-ci/travis-ci#9923

@matthid
Copy link
Member Author

matthid commented Jul 28, 2018

Ok:

  • AppVeyor is now running besides two tests. I hope @forki can take a look at one of them next week. The second looks like some regression in the FLAKY testsuite.
  • Travis is now broken globally for us because of the linked issue.

@matthid matthid mentioned this pull request Jul 29, 2018
Closed
@forki forki merged commit c4c58c0 into master Jul 30, 2018
matthid added a commit that referenced this pull request Aug 23, 2018
@matthid
Fix another instance of #3307
85e3b12
@matthid matthid mentioned this pull request Aug 23, 2018
Merged
@matthid matthid deleted the winhttphandler branch July 2, 2019 17:15
@matthid matthid mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthid @forki