Env vars fix #3293
Merged
Env vars fix #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inosik
reviewed
Jul 12, 2018
| else "") | ||
| else "" | ||
| with | ||
| | _ -> "") |
There was a problem hiding this comment.
Should we print the exception message and the bad path?
There was a problem hiding this comment.
Maybe always print something like "Error when searching <file> in <path>" and print exception message only in verbose mode?
Or print everything only in verbose?
There was a problem hiding this comment.
I'd print that as a warning, otherwise people might not even be aware that they have something invalid in their PATH.
There was a problem hiding this comment.
I think it can be confusing to see warn about some strange path after hit paket restore in random repository.
And in tryFindFile we dont know source of dirs parameter.
So i'm inclined to verbose-only trace.
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3290
plus expand env vars in env vars values to correctly process PATH like
%SystemRoot%or%UserProfile%/something