Add support for dotnet SDK fallback folder #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dotnet SDK ships with various .NET Core and ASP.NET Core nuget packages in a NuGetFallbackFolder. This changes to try to find packages in that folder before looking in other caches or downloading from source. In the event the package is found here, the contents are copied or linked directly from that folder instead of the user's cache.
forki
reviewed
Jun 8, 2018
| @@ -331,6 331,21 @@ let GetTargetUserNupkg (packageName:PackageName) (version:SemVerInfo) = | |||
| let GetTargetUserToolsFolder (packageName:PackageName) (version:SemVerInfo) = | |||
| DirectoryInfo(Path.Combine(Constants.UserNuGetPackagesFolder,".tools",packageName.CompareString,version.Normalize())).FullName | |||
|
|
|||
| let TryGetFallbackFolder () = | |||
| let dotnet = if isUnix then "dotnet" else "dotnet.exe" | |||
There was a problem hiding this comment.
can we do it without calling dotnet?
There was a problem hiding this comment.
I'm just using it to find the folder, it's not executed. I guess the alternative is to try the default folder depending on platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotnet SDK ships with various .NET Core and ASP.NET Core nuget packages in a NuGetFallbackFolder.
This changes to try to find packages in that folder before looking in other caches or downloading from source. In the event the package is found here, the contents are copied or linked directly from that folder instead of the user's cache.
Paket resolves a few packages with higher versions than the ones that ship, so this doesn't eliminate all downloads, but it makes a very significant dent. A before/after when starting with an empty cache for a project referencing
Microsoft.AspNetCore.App:Before
After
We could go further: I'd guess this won't work when e.g. FAKE does a local install of the dotnet SDK as that folder won't be on the path. It seems that there's an MSBuild property available during restore (as I mentioned in #2827 (comment)) that we could pass to
paket.exewhen called inPaket.Restore.targets.Fixes #2827