Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer search for CredentialProviders on an empty path. #3214

Merged
merged 1 commit into from
May 23, 2018
Merged

No longer search for CredentialProviders on an empty path. #3214

merged 1 commit into from
May 23, 2018

Conversation

ninjarobot
Copy link
Contributor

In some unusual scenarios like a paket mkbundle, Path.GetDirectoryName on an Assembly.Location returns an empty string. When that happens, Directory.EnumerateFiles will eventually call Path.InsecureGetFullPath on mono, resulting in this error:

System.ArgumentException: The specified path is not of a legal form (empty).

coming from here.

Switching to String.IsNullOrEmpty addresses that issue.

@forki
Copy link
Member

forki commented May 23, 2018

thx

@forki forki merged commit 8be8743 into fsprojects:master May 23, 2018
@ninjarobot ninjarobot deleted the mono_enumeratefiles_fix branch May 24, 2018 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ninjarobot @forki @matthid