Update magic mode file location #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some companies (mine included) block the running of exe in any of the app data folders as this is where malware typically embeds itself. It is possible to put folder exclusions into group policy, but since paket was just going into the root of the temp folder it is not possible to unblock it. This change will put the downloaded magic paket.exe into a paket folder.
|
/cc @vbfox |
|
@forki are the ci failures mine? On appveyor one of the builds pass, but on all others they fail. |
|
I guess it's unrelated
Chris Blyth <[email protected]> schrieb am Fr., 11. Mai 2018, 19:29:
… @forki <https://github.com/forki> are the ci failures mine? On appveyor
one of the builds pass, but on all others they fail.
It's kinda confusing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3197 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNIqeVd_zBlPrCBRa__KvUn2y-vBZks5txcphgaJpZM4T7Ayw>
.
|
vbfox
suggested changes
May 11, 2018
|
|
||
| return Path.Combine(fileSystemProxy.GetTempPath(), targetName); | ||
| var targetFolder = Path.Combine(fileSystemProxy.GetTempPath(), "paket"); | ||
| Directory.CreateDirectory(targetFolder); |
There was a problem hiding this comment.
Please use fileSystemProxy here (it should have a CreateDirectory method too)
vbfox
approved these changes
May 12, 2018
|
Yes I think so, I approved the changes but don't have access to the repo to merge. |
|
Oh sorry, I didn't realise that, just waiting on @forki then 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some companies (mine included) block the running of exe in any of the app data folders as this is where malware typically embeds itself.
It is possible to put folder exclusions into group policy, but since paket was just going into the root of the temp folder it is not possible to unblock it.
This change will put the downloaded magic paket.exe into a paket folder.