Fix the optimization for restore bypassing argu #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I limited myself to "restore" without arguments by design, because I didn't want to introduce our own argument parser. But it seems like we have to give up and implement our own over time ;) |
|
@matthid adding the variants was just to get the perf gain in more cases. The bugfix was to ignore the first element of the array, the previous code never triggered |
|
released in 5.150.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current optimization to bypass argu doesn't work because the first element in the arguments is the current executable path.
So I fixed it and also added support for
restore --projectthat the SDK projects target uses, and forinstallas it's one of the most used command