Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .NETCoreApp2.1 and UAP10.0.16300 tfms #3094

Merged
merged 5 commits into from
Mar 1, 2018
Merged

Add .NETCoreApp2.1 and UAP10.0.16300 tfms #3094

merged 5 commits into from
Mar 1, 2018

Conversation

sliepie
Copy link
Contributor

@sliepie sliepie commented Feb 27, 2018

Possible fix for #3081

When restoring fake-bootstrap, errors were appearing about .NETCoreApp2.1 and UAP10.0.16300 TFMs
Added these TFMs to FrameworkHandling.fs and fixed broken tests. If more changes are needed, let me know

@forki
Copy link
Member

forki commented Feb 28, 2018 •
edited
Loading

the fix looks good, but still red integration tests.

@sliepie
Copy link
Contributor Author

sliepie commented Feb 28, 2018

Yeah, I broke tests while trying to fix them, will look into it.

@sliepie sliepie force-pushed the tfms-uap10.0.16300-netcoreapp2.1 branch from ee49c48 to f2f503b Compare February 28, 2018 09:22
@sliepie sliepie force-pushed the tfms-uap10.0.16300-netcoreapp2.1 branch from f2f503b to 0d25690 Compare February 28, 2018 09:24
@forki
Copy link
Member

forki commented Feb 28, 2018

can you please merge master. that may fix couple of tests

@sliepie
Copy link
Contributor Author

sliepie commented Feb 28, 2018

Integration tests are passing on local machine, except 1:

1) Error : Paket.IntegrationTests.NuGetV3Specs.#2700-1 v3 works properly
System.Exception : Paket failed with
-> Unable to retrieve package versions for 'Microsoft.CSharp'

@forki
Copy link
Member

forki commented Mar 1, 2018

thank you!

@forki forki merged commit bd1efaa into fsprojects:master Mar 1, 2018
@sliepie sliepie deleted the tfms-uap10.0.16300-netcoreapp2.1 branch March 1, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sliepie @forki