Fix bug when attempting to pack multi-target frameworks #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed?
…On Mon, 26 Feb 2018, 09:41 Steffen Forkmann, ***@***.***> wrote:
Closed #3073 <#3073>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3073 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACrts0aiO8YURB9YAmfAeI7Z10SxnbLtks5tYmApgaJpZM4SSXrO>
.
|
|
Merged but rebased because I fucked up. Will be rel with next release
Am 26.02.2018 09:30 schrieb "Eirik Tsarpalis" <[email protected]>:
… Closed?
On Mon, 26 Feb 2018, 09:41 Steffen Forkmann, ***@***.***>
wrote:
> Closed #3073 <#3073>.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#3073 (comment)>, or
mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/
ACrts0aiO8YURB9YAmfAeI7Z10SxnbLtks5tYmApgaJpZM4SSXrO>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3073 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNIF6f-PGF7Hkvvj35PKb2_0sWeOsks5tYmu6gaJpZM4SSXrO>
.
|
|
Ah, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a more conservative fix than the one attempted in #3070. Hopefully this will not result in any regressions.
It should be noted that this doesn't implement proper support for multi-target packing, but lets package authors work around the problem by explicitly specifying package contents.