Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] add overload for Dependencies.Init #3019

Merged
merged 3 commits into from
Jan 31, 2018
Merged

[API] add overload for Dependencies.Init #3019

merged 3 commits into from
Jan 31, 2018

Conversation

enricosada
Copy link
Collaborator

add overload to Dependencies.Init to:

  • specify sources
  • choose if download bootstrapper
  • additional global config in deps

matthid
matthid approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/Paket.Core/PublicAPI.fs
|> returnOrFail
)

#if !NO_BOOTSTRAPPER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know that flag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that to disable boostrapper on .net core. was not working anyway, no need to download it

@forki forki merged commit 9b244da into fsprojects:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid approved these changes

@forki forki Awaiting requested review from forki

Assignees
No one assigned
Labels
api enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enricosada @matthid @forki