Trace not-found and blacklist warnings as actual warnings #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce per query and source combination
forki
reviewed
Jan 18, 2018
| @@ -301,7 312,7 @@ let rec private getPackageDetails alternativeProjectRoot root force (parameters: | |||
| return! tryV3 nugetSource force | |||
| with | |||
| | exn -> | |||
| eprintfn "Possible Performance degradation, V3 was not working: %s" exn.Message | |||
| traceWarnfn "Possible Performance degradation, V3 was not working: %s" exn.Message | |||
|
wow you are on fire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific explicitly handled and repeated "errors" are changed to "warn if not before" to avoid stderr writes and/or console/log flooding when the resolver actually continues and can succeed.
Trace not-found and blacklist warnings as actual warnings, and only once per query and source combination.