-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate nuspecs in IntermediateOutputPath #2871
Conversation
Pinging @matthid because I'm on vacation |
@johlrich can you please take a look at the broken test in appveyor |
Looks like I didn't test with the IntermediateOutputPath variable enough. That one includes the configuration and the target framework in the path. I switched back to |
Mhm still red? |
Maybe the test is no good? |
Hmmmmm the test passes locally after switching. The test also fails here without the changes complaining about no description, and when looking at the in the scenario temp folder I see the same situation as the issue: an extra blank nuspec at obj root. Not sure why it's passing now. Strange that I'm getting the opposite results as appveyor. Not really sure of a good way to troubleshoot atm. @forki any ideas? My only thought was to somehow capture the scenario temp folder from the appveyor build to take a closer look in both scenarios, but not sure how to do that tbh. |
Maybe different dotnet cli versions?
Am 29.10.2017 15:35 schrieb "Jonathan Ohlrich" <[email protected]>:
… Hmmmmm the test passes locally after switching. The test also fails here
without the changes complaining about no description, and when looking at
the in the scenario temp folder I see the same situation as the issue: an
extra blank nuspec at obj root. Not sure why it's passing now.
Strange that I'm getting the opposite results as appveyor. Not really sure
of a good way to troubleshoot atm. @forki <https://github.com/forki> any
ideas?
My only thought was to somehow capture the scenario temp folder from the
appveyor build to take a closer look in both scenarios, but not sure how to
do that tbh.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2871 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNAciZT8ZLldpDj6X_iokUlmvKWY1ks5sxI02gaJpZM4QJ4Ux>
.
|
@forki I think that's it. I isolated that one test and then ran it with Going to change to 2.0.2 so appveyor gets kicked off again with it to prove that out there. If that works then we'll have to see how you want to handle that. 🤞 |
More weirdness, the full build is currently churning through the integration tests on my machine with 2.0.2 but appveyor can't seem to get past restoring Paket.Core.preview3. Edit: Build finished and all tests passed locally when using 2.0.2 the RunIntegrationTests target |
Yes changing the dotnet cli version is not the solution here
Am 29.10.2017 20:10 schrieb "Jonathan Ohlrich" <[email protected]>:
… More weirdness, the full build is currently churning through the
integration tests on my machine with 2.0.2 but appveyor can't seem to get
past restoring Paket.Core.preview3.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2871 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNIOhbWNJ4kf9Gxhx16VYH_hMwyu4ks5sxM2-gaJpZM4QJ4Ux>
.
|
nuspecs started appearing in obj/configuration/ with dotnetcli 2.0.2
Ok, it is now checking for existence in the new location and if it couldn't find it, falling back to the old location. Build finally green and worked with both cli versions here. Not super familiar with MSBuild so let me know if there was a simpler way to do that since Exists doesn't seem to do wildcards |
this is so they go in obj/Configuration/ instead of obj/
closes #2865