Adding PAKET_VERSION posix compliant environment variable for bootstrapper #2857
Conversation
|
/cc @vbfox |
|
I was hit by this before so I’m happy that someone takes care of this :) |
docs/content/bootstrapper.md
Outdated
|
|
||
| ### Setting version in magic mode | ||
|
|
||
| There are a few ways to set the version requested in magic mode. |
There was a problem hiding this comment.
This section seem to summarize what's already in the file : why ?
Also :
- It's missing the nicest way to do that : add
version x.y.zto thepaket.dependenciesfile - The existing documentation on Environment variables isn't changed with the new name (Keeping compat is nice but I don't think the non-posix version need to be documented).
There was a problem hiding this comment.
Seemed non-obvious for magic mode to me. Maybe I should trim it to just mentioning paket.exe.config ?
There was a problem hiding this comment.
Think it's worth moving the how to do env var commands to under the env var heading?
There was a problem hiding this comment.
👍 on latest, maybe specifying in the Setting version in magic mode section that all methods (except for the command line one) works in this mode (with the note about renaming). But it can be changed later.
TheAngryByrd
force-pushed
the
bootstrapper-version-envvar-posix
branch
2 times, most recently
from
7c5e3eb
to
8ad4a65
Compare
docs/content/bootstrapper.md
Outdated
| ``` | ||
| * cmd | ||
| ``` | ||
| set PAKET_VERSION "5.119.7" |
There was a problem hiding this comment.
Missed that one, syntax for cmd is
set PAKET_VERSION=5.119.7
8ad4a65
to
731f56a
Compare
|
Ping 🏓 |
What's the issue?
Paket boostrapper supplies a way to use environment variables to instruct it which version of paket to get.
https://github.com/fsprojects/Paket/blob/master/src/Paket.Bootstrapper/ArgumentParser.cs#L40
However
PAKET.VERSIONis not posix compliant. Instead of just changing it as it might be a breaking change I've just added a new variable compliant for posix and windows.I've also added docs on how to obtain different versions using
paket.exe.configor environment variables in the docs.