Minor perf improvement for why command #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking it twice as fast is not "minor" ;-)
Am 17.10.2017 23:00 schrieb "Tomasz Heimowski" <[email protected]>:
… I got from 6s down to 3s on my box for the original case #2844
<#2844>
This replaces Map with IDictionary and cycle dependency prevention is a
bit faster now
------------------------------
You can view, comment on, or merge this pull request online at:
#2851
Commit Summary
- Why command - replace Map with Dictionary, optimize `removeEdge`
File Changes
- *M* src/Paket.Core/PackageAnalysis/Why.fs
<https://github.com/fsprojects/Paket/pull/2851/files#diff-0> (35)
Patch Links:
- https://github.com/fsprojects/Paket/pull/2851.patch
- https://github.com/fsprojects/Paket/pull/2851.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2851>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNLVzP97DMIkYujlBex14l1Fb7Ip5ks5stRV6gaJpZM4P80Hq>
.
|
|
in #2853 I replaced the set with a hashset. Not sure if it's still correct?! Can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got from 6s down to 3s on my box for the original case #2844
This replaces
MapwithIDictionaryand cycle dependency prevention is a bit faster now