Implement stricter parsing in Requirements.parseRestrictionsLegacy (take 2) #2824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes reverted PR #2816, which caused issue #2822
It seems some existing files in the wild incorrectly used e.g.
frameworks: net40
instead offramework: net40
, and the previous 'loose' parsing would parse the resulting expressions net40
as= net40
. The stricter version previously merged would bail ass
isn't a valid framework.This PR changes to first check for
frameworks
and thenframework
meaning the two are now interchangeable and existing files such as those described in #2822 will continue to work.