we need to prefer package over group settings #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah OK I found the reason: Should it? |
5 tasks
|
My guess: GenerateLoadScripts was added after the record was created, and the adder forgot to update the operator? See commit f616c8b I created fsharp/fslang-suggestions#603 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to prefer package over group settings, fixes #2682
Note: I didn't fully understand the root cause but (especially why a particular comparison contained "None"), but it seems to be obvious that we need to prefer package over group settings (and therefore have them in front of the " "). @forki could you please quickly review if that makes sense?
This might have lead to incorrect comparisons of restrictions (but I don't get why I saw in the debugger a comparsion of "generate_load_scripts = Some true" with "generate_load_scripts = None"
From my understanding it should never be "None" no matter the order of the arguments?!