[WIP] Fix Feed Warnings and add blacklisting #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is green - that makes me even more nervous ... |
|
can you please rebase? thanks |
This was referenced Aug 10, 2017
Closed
…st feeds. mr proper
matthid
force-pushed
the
fix_server_warning_2537
branch
from
64eea70
to
08d578d
Compare
|
Ok rebased. For some strange reason it feels slower, maybe wrong. |
|
CI failure is unrelated to this PR and in master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial sketch at trying to remove repeated feed warnings and blacklist feeds.
I think this implementation has still some problems:
This is not trivial to fix and probably needs some trial and error with real feeds. And me going though all the old issues again ...
This should in effect reduce the amount of warnings and at the same time improve the performance by less "doomed to fail" requests. Lets see what the CI says.