fail when a sdk f# project does not contain a reference to fsharp.core

I don't think we need to do that. This is basically a thing that will happen later in build. We should not have this in paket.exe itself.

I don't think we need to do that. This is basically a thing that will happen later in build. We should not have this in paket.exe itself

Thats the big issue - if you dont' pass any FSharp.Core to the compiler, it will silently pick any random one.

if you dont' pass any FSharp.Core to the compiler, it will silently pick any random one

how? I think the targets file changes forbid that!?

Please test it, maybe i missed something, but afaik it does not error out.

If you have a repro? Can you please report that to visualfsharp? It should not implicitly add things when you explicitly set the flag, right?

Will do

can you please send a second PR that only sets the properties in the targets file?

I don't think that is a good idea.

When you do dotnet new and paket convert, the resulting project will be broken (and still compiling, so the user doesn't notice it).

I would say let's wait for a response on that issue, maybe there is a compilerflag to disable the magic core reference?

Great, locally I have the same three PathTooLongException failures, but I also have one that may be more interesting:

Edit:

Cause:

The specified SDK version [2.0.0-alpha-005165] from global.json [C:\source\Paket\global.json] not found; install specified SDK version
Did you mean to run dotnet SDK commands? Please install dotnet SDK from:
http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

It is picking up the global.json from the paket root folder. Probably a good idea to hardcode the cli version.

It feels like this test needs to be reworked. It's not working on travis either, see here

I need to test if it actually works (probably doesn't, I know myself =) ), and a few unit tests would also be nice, but from my side this is mostly finished.

As it stands, it adds FSharp.Core on convert-from-nuget and warns (I downgraded it from an error) on install if a v15 F# project does not reference FSharp.Core.

What do you think?

Manual test:

1. dotnet new lib -lang F#
2. paket convert-from-nuget
3. Check that both paket.dependencies and paket.references contain FSharp.Core ✔
4. manually remove FSharp.Core from paket.references
5. Check that a warning was printed ✔
   

CI fails with __ PathTooLongException__ :\

what is the status?

Ready from my side.

CI errors seem unrelated, but please verify.

I've rebased it on master, which wiped the CI history, so here is a link to the previous CI result: https://ci.appveyor.com/project/SteffenForkmann/paket/build/0.0.1.9005

AppVeyor: PathTooLongException
Travis: each stage passed at least once ;-)

Maybe we can add long-path support for the test suite on appveyor (via App.Config). We don't really care about too long paths there. As the appveyor is green on master and our only check right now I think we need it to be green here as well. Or we wait for #2584?

Kay, let me shorten the scenario names a bit ...

@matthid green

If I understand it correctly, Pack does a Restore, which goes to github, and doesn't seem to be cached.

Would be interesting to see WHAT is not cached. We had some problems with the bootstrapper in the past (where dotnet was calling the bootstrapper in magic mode).
Maybe we need to set some verbose flags:

• PAKET_BOOTSTRAPPER_TRACE=true allows to set the bootstrapper into verbose mode.
• you maybe can temporarily add "-v" to the paket targets file.

This is when this error is actually reproducible.

no idea - I think this may not actually be an issue with paket, because the build in my fork also failed with the same error. So it seems the AppVeyor Datacenter as a whole hit the limit.

Anyway, now it is green again.

thanks!