Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in the references file. #2477

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Conversation

fsoikin
Copy link
Contributor

@fsoikin fsoikin commented Jun 30, 2017

Fixes #2371.

@forki
Copy link
Member

forki commented Jul 1, 2017

Cool!

@forki forki merged commit 5dc3772 into fsprojects:master Jul 1, 2017
@fsoikin
Copy link
Contributor Author

fsoikin commented Jul 2, 2017

@forki note that this may become a breaking change under some very specific circumstances: before this, the removeComment function allowed comments to start anywhere, but now comments have to start either at the beginning of the line or after a space.

Also, I have realized that a comment can start after a space, but not after a tab. Do you think it would be a good idea to update it to allow tabs as well? Or perhaps anything that is Char.IsWhitespace?

@forki
Copy link
Member

forki commented Jul 2, 2017

Char.iswhitespace sounds good

@fsoikin
Copy link
Contributor Author

fsoikin commented Jul 2, 2017

Got it. #2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants