downgrade to tooling 1.0 #2380
downgrade to tooling 1.0 #2380
Conversation
|
I didn't run any tests locally, let's see what the CI says. |
|
@forki What's up with the build? :D |
|
I would prefer to just add the nuget FSharp.Compiler.Tools instead of hardcoding a few different paths. What do you think? |
|
Yes if it works I'm fine with that. nice! |
|
Build now works, but one unit test failed. On it! The great thing about the nuget is that this will allow compatibility with VS 2015 and F# vLatest. For example, if you use struct tuples, you will get red squiggles in the ide, but can still build and run / debug. |
|
Yes very nice! btw you can test with the appveyor artefact how this change will impact your scenario (sorry i'm on mobile today and tomorrow...) or just build locally obviously |
|
Please review if the unit test changes are actually correct. |
| | DotNetFramework FrameworkVersion.V5_0 -> [ DotNetFramework FrameworkVersion.V4_6_2; DotNetStandard DotNetStandardVersion.V1_5 ] | ||
| | DotNetFramework FrameworkVersion.V4_6_3 -> [ DotNetFramework FrameworkVersion.V4_6_2 ] | ||
| | DotNetFramework FrameworkVersion.V4_7 -> [ DotNetFramework FrameworkVersion.V4_6_3] | ||
| | DotNetFramework FrameworkVersion.V5_0 -> [ DotNetFramework FrameworkVersion.V4_6_2 ] |
| @@ -154,7 154,7 @@ let ``should understand reference folder``() = | |||
| model.GetRuntimeAssemblies RuntimeGraph.Empty (Rid.Of "unix") (SinglePlatform (DotNetFramework FrameworkVersion.V4_6_3)) | |||
| |> Seq.map (fun f -> f.Library.Path) | |||
| refs |> shouldNotContain @"..\System.Security.Cryptography.Algorithms\runtimes\win\lib\net46\System.Security.Cryptography.Algorithms.dll" | |||
| refs |> shouldContain @"..\System.Security.Cryptography.Algorithms\lib\netstandard1.6\System.Security.Cryptography.Algorithms.dll" | |||
| refs |> shouldNotContain @"..\System.Security.Cryptography.Algorithms\lib\netstandard1.6\System.Security.Cryptography.Algorithms.dll" | |||
| refs |> shouldNotContain @"..\System.Security.Cryptography.Algorithms\ref\netstandard1.6\System.Security.Cryptography.Algorithms.dll" | |||
There was a problem hiding this comment.
Can we add a similar test that checks if the rid stuff works, but now with a lower netstandard?
Because now all those changed to shouldnotcontain here so the test no longer tests that...
|
Looks good. Travis failure is not related to this PR. |
see https://docs.microsoft.com/en-us/dotnet/standard/library
ref #2378