collect multiple install errors before failing #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudRoutine
force-pushed
the
collect-errors
branch
from
368dbaa
to
c754314
Compare
cloudRoutine
changed the title
vs2017 fsproj use tools version 15 by default but do not use the new msbuild format. Paket will now check for the 'Sdk' attribute to ensure it's the new format, to make sure it adds package references to the fproj when it's supposed to.
|
@forki the last commit takes care of the bug I found yesterday. |
|
Cool thanks. Can you please send another pull request that adds this to the release notes? Thx BTW next week I want to go rc or even release paket 4 |
|
I meant an actual text entry with the feature description ;-)
Am 10.03.2017 01:49 schrieb "Jared Hester" <[email protected]>:
… @forki <https://github.com/forki> like this #2181
<#2181> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2177 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNK2SZGuhW8RAAxzaZyDo4T4wXMP7ks5rkJ39gaJpZM4MVM6->
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needing to run install several times in a row to get one successive error is a tedious chore, instead let's collect them and return them all at once.