Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitHub dependencies with spaces #2127

Merged
merged 6 commits into from
Jan 29, 2017
Merged

Support GitHub dependencies with spaces #2127

merged 6 commits into from
Jan 29, 2017

Conversation

inosik
Copy link
Contributor

@inosik inosik commented Jan 28, 2017

This should enable support for GitHub dependencies which contain spaces in their file name.

@inosik
Enclose file names with quotes
6d3cefd 
Also, test the new behavior.
@inosik inosik mentioned this pull request Jan 28, 2017
Closed
@forki
Copy link
Member

forki commented Jan 28, 2017

this doesn't compile!?

@inosik inosik force-pushed the bugfix/#2114-filenames-with-spaces branch from 688e336 to 065846a Compare January 28, 2017 17:13
@inosik
Copy link
Contributor Author

inosik commented Jan 28, 2017

I always forget that String.Contains doesn't accept chars 😅

@inosik
Copy link
Contributor Author

inosik commented Jan 28, 2017

Okay, I will look at the failing tests.

@forki forki merged commit 6c38f14 into fsprojects:master Jan 29, 2017
@inosik inosik deleted the bugfix/#2114-filenames-with-spaces branch January 29, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inosik @forki