Correctly escape no_proxy domains #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
This broke one of the nunit bootstrapper tests. Please take a look at the appveyor build output (Travis is red for unrelated reason). Can you please send me a PR with a fix? Thanks |
juergenhoetzel
added a commit
to juergenhoetzel/Paket
that referenced
this pull request
Jan 2, 2017
The BypassList property contains an array of regular expressions.
forki
added a commit
that referenced
this pull request
Jan 2, 2017
Fix bootstrapper test broken by #2100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrapping fails on my setup, because I use wildcard in
NO_PROXY:This is actually the same issue as #1939 which also need to be fixed in the bootstrapping code.