Don't remove group with only remote files #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes failure when path contains spaces. - Extracted restore command to separate MSBuild variable instead of having to XML attribute-escape the quotes.
|
cool thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the test first and confirmed it failed. I've not yet had time to see if there are any similar bugs in other areas of the dependencies code - only taken a look at the removal case so far.
Edit: I've also added an extra fix for building on a path with spaces, though this still fails after due to a similar bug in the dotnet core targets file which I've reported here: dotnet/netcorecli-fsc#59