One of the file writes was missing a Directory.Create() #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't actually causing a bug but this makes the functions to create fsharp and csharp scripts more consistent, and it's confusing if the code relies on file creation order for fsharp scripts but not csharp scripts
jamesjrg
force-pushed
the
generate-include-scripts-fails
branch
from
3a280c5
to
b957295
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate-include-scripts used ToLowerInvariant() on the full path name which caused issues in Linux that wouldn't appear in Windows. Though apparently wasn't an issue on Macs? not sure why that would be, I don't have a mac.
At first I thought the issue was the lack of Directory.Create() before File.WriteAllText for some files, but turned out this wasn't the issue due to file creation order meaning the directory was actually already there.
Regardless I changed it so in the function to write fsharp scripts it does a Directory.Create immediately before writing, which makes the functions to create fsharp and csharp scripts more consistent, and I think it's less confusing